Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-785: fix validation when creating a monitoring instance #407

Merged
5 commits merged into from
Jan 29, 2024

Conversation

ghost
Copy link

@ghost ghost commented Jan 26, 2024

EVEREST-785 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
EVEREST-785

Monitoring instance was not properly configured when username was empty.

Cause:
API validation did not properly check input parameters.

Solution:
Updated validation

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@ghost ghost requested review from recharte and oksana-grishchenko as code owners January 26, 2024 16:04
@ghost ghost enabled auto-merge (squash) January 26, 2024 16:05
Michal Kralik added 2 commits January 26, 2024 17:22
api/validation.go Outdated Show resolved Hide resolved
api/validation.go Show resolved Hide resolved
@ghost ghost merged commit 74d7782 into main Jan 29, 2024
4 checks passed
@ghost ghost deleted the EVEREST-785-monitoring-instance-validation branch January 29, 2024 09:28
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants